Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.6.3] VMenu dismisses on enter keypress when inner textarea is focused #19767

Closed
curtgrimes opened this issue May 7, 2024 · 0 comments · Fixed by #19768
Closed

[Bug Report][3.6.3] VMenu dismisses on enter keypress when inner textarea is focused #19767

curtgrimes opened this issue May 7, 2024 · 0 comments · Fixed by #19768
Assignees
@curtgrimes @johnleider
Labels
C: VMenu VMenu C: VTextarea VTextarea T: bug Functionality that does not work as intended/expected
Milestone
v3.6.x

Comments

@curtgrimes
Copy link
Contributor

Environment

Vuetify Version: 3.6.3
Last working version: 3.5.14
Vue Version: 3.4.27
Browsers: Chrome 124.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

  1. Have a <v-menu /> with :close-on-content-click="false".
  2. Put a <v-textarea/> or a plain <textarea> in the menu.
  3. Open the <v-menu />, focus the <textarea>, and press enter while focus is in the textarea.

Expected Behavior

A new line is typed into the textarea.

Actual Behavior

The menu dismisses.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

3.5.14 (correct behavior):

Screenshot 2024-05-07 at 10 48 40

3.5.15 (incorrect behavior):

Screenshot 2024-05-07 at 10 48 50

Possibly related code change: 85ba4a8
curtgrimes added a commit to curtgrimes/vuetify that referenced this issue May 7, 2024
@curtgrimes
fix(VMenu): allow enter keypress to work in textareas
054aea4 
Previously, when a `<v-menu />` with `:close-on-content-click="false"`
contained a textarea, an enter press inside the textarea would do
nothing and not produce a new line. Now, it will allow a new line to be
typed into the textarea when pressing enter.

This last worked in Vuetify v3.5.14 and was broken starting in v3.5.15.
The fix for vuetifyjs#19519 in 85ba4a8 caused this issue.

fixes vuetifyjs#19767
@curtgrimes curtgrimes mentioned this issue May 7, 2024
Merged
johnleider pushed a commit that referenced this issue May 13, 2024
@curtgrimes
fix(VMenu): allow enter keypress to work in textareas (#19768)
19ddcef 
fixes #19767
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VTextarea VTextarea C: VMenu VMenu and removed S: triage labels May 13, 2024
@johnleider johnleider added this to the v3.6.x milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curtgrimes curtgrimes

@johnleider johnleider

Labels
C: VMenu VMenu C: VTextarea VTextarea T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.6.x
Development

Successfully merging a pull request may close this issue.

fix(VMenu): allow enter keypress to work in textareas curtgrimes/vuetify
2 participants
@curtgrimes @johnleider