Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prevent routing in mobile when tab the native back button if dialog in open state #3085

Closed
ksankumar opened this issue Jan 23, 2018 · 3 comments
Labels
duplicate The issue has already been reported T: feature A new feature

Comments

@ksankumar
Copy link

ksankumar commented Jan 23, 2018

@KaelWD

New Functionality

Android mobile hybrid app:: We have 2 pages and imagine and in 2nd page with v-select options, dialogs, date-picker and else

  1. Click the Select option in 2nd page, once opened select option - tab the mobile native back button(Android)
  2. See the screen. Select option got closed(Expected behaviour), and page navigated to previous page(Un-expected behaviour)

How can we prevent page routing for click native back button, when select option opened

Improvements

beforeRouteLeave in event components and checking whether select, dialogs, date-picker in open state

Bugs or Edge Cases it Helps Avoid

Vuetify may prevent routing if any modal opened like date-picker, dialogs, select and so

@ksankumar ksankumar changed the title [Feature Request] Prevent routing in mobile when tab the native back button [Feature Request] Prevent routing in mobile when tab the native back button if dialogs open Jan 23, 2018
@ksankumar ksankumar changed the title [Feature Request] Prevent routing in mobile when tab the native back button if dialogs open [Feature Request] Prevent routing in mobile when tab the native back button if dialog in open Jan 23, 2018
@johnleider johnleider added help wanted We are looking for community help T: feature A new feature labels Jan 25, 2018
@ksankumar
Copy link
Author

ksankumar commented Jan 26, 2018

For temp fix

beforeRouteLeave: function(to, from, next) {
    var active_window = this.$refs,
        isNotActive = true;
    for (var ref in active_window) {
        if (active_window[ref].isActive) {
            active_window[ref].isActive = false;
            isNotActive = false;
            next(false);
        }
    }
    isNotActive && next();
}

@KaelWD
Copy link
Member

KaelWD commented Feb 11, 2018

Original conversation:
image

@ksankumar ksankumar changed the title [Feature Request] Prevent routing in mobile when tab the native back button if dialog in open [Feature Request] Prevent routing in mobile when tab the native back button if dialog in open state Feb 13, 2018
@KaelWD
Copy link
Member

KaelWD commented May 16, 2018

Turns out this is actually a duplicate of #1793

@KaelWD KaelWD marked this as a duplicate of #1793 May 16, 2018
@KaelWD KaelWD closed this as completed May 16, 2018
@KaelWD KaelWD added duplicate The issue has already been reported and removed help wanted We are looking for community help labels May 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate The issue has already been reported T: feature A new feature
Projects
None yet
Development

No branches or pull requests

3 participants