Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add slots for v-carousel controls #3235

Closed
jeck5895 opened this issue Feb 9, 2018 · 7 comments · Fixed by #12602
Closed

[Feature Request] add slots for v-carousel controls #3235

jeck5895 opened this issue Feb 9, 2018 · 7 comments · Fixed by #12602
Assignees
Labels
C: VCarousel VCarousel T: feature A new feature
Milestone

Comments

@jeck5895
Copy link

jeck5895 commented Feb 9, 2018

New Functionality

I want to set thumbnails of the images as the carousel controls

Improvements

there are no work around for this feature at the moment.

Bugs or Edge Cases it Helps Avoid

doesnt solve any bugs, but may allow for a richer and more customizable interface.

@nekosaur nekosaur added the pending review The issue is still pending disposition label Feb 12, 2018
@nekosaur
Copy link
Member

nekosaur commented Mar 8, 2018

This could be supported by allowing the use of slots for the next/prev controls

@jeck5895
Copy link
Author

jeck5895 commented Mar 8, 2018

Sorry but I don't get it... Can you elaborate it?

@johnleider johnleider added maybe Functionality that we are considering and removed pending review The issue is still pending disposition labels Apr 5, 2019
@johnleider johnleider added this to the v2.x.x milestone Apr 5, 2019
@blalan05 blalan05 added the C: VCarousel VCarousel label Apr 9, 2019
@jacekkarczmarczyk jacekkarczmarczyk added the T: feature A new feature label Aug 1, 2019
@johnleider johnleider removed this from the v2.x.x milestone Jan 19, 2020
@killbotXD
Copy link

@jeck5895 I had one more suggestion. We can also have custom text on the delimiters rather than Icons/Images.
I was trying to make a carousel like this but couldn't find any method to add text inside delimiters.
It would be nice if someone working on this issue tries to do this also.
Screenshot from 2020-03-19 14-17-48

@killbotXD
Copy link

same can be done to the carousel controls.

@chasedougherty4628
Copy link

chasedougherty4628 commented Jul 8, 2020

I know you can simply add the images and then change the "value" attribute on the v-carousel element. This will allow you to change to the selected image. It would be great if we can add to the documentation that you can change the current carousel item by setting the value on the carousel. That is if it's supported

<v-carousel
    hide-delimiters
    :value="currentCarousel"
  >
    <v-carousel-item
      v-for="(component, index) in products()"
      :key="index"
    >
      <div class="justify-center d-flex flex-column align-center">
        <h3 class="red--text text--darken-3 text-center">
          Products
        </h3>
        <h1 class="text-center font-weight-bold pb-8">
          {{ component.attributes.displayName }}
        </h1>
        <v-img
          :contain="true"
          max-width="1000"
          max-height="700"
          :src="require(`@/assets/images/dimensions/${component.attributes.imageName}`)"
        />
        <!-- pictures below picture -->
        <div class="justify-center d-flex">
          <div
            v-for="(product, i) in productsWithDimensions()"
            :key="i"
            class="pa-2"
          >
            <v-img
              :contain="true"
              max-width="80"
              max-height="70"
              :src="require(`@/assets/images/dimensions/${product.attributes.dimensionImageName}`)"
              :class="index === i ? 'selected-image-color' : ''"
              @click="currentCarousel = i"
            />
          </div>
        </div>
      </div>
    </v-carousel-item>
  </v-carousel>

@nekosaur nekosaur changed the title [Feature Request] carousel images itself to be put on delimiter-icon as an option in addition to icons. [Feature Request] add slots for v-carousel controls Nov 11, 2020
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Nov 12, 2020
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.4.0 milestone Nov 12, 2020
@jacekkarczmarczyk jacekkarczmarczyk added S: has PR The issue has a pending Pull Request and removed maybe Functionality that we are considering labels Nov 12, 2020
@jacekkarczmarczyk jacekkarczmarczyk linked a pull request Nov 12, 2020 that will close this issue
8 tasks
KaelWD pushed a commit that referenced this issue Nov 17, 2020
Co-authored-by: Albert Kaaman <albert@kaaman.nu>

see #3235
@KaelWD
Copy link
Member

KaelWD commented Nov 17, 2020

prev/next slots added in #12602, delimiter slots may come in some future version.

@johnleider johnleider added this to To do in Vuetify 3 - Titan via automation Nov 30, 2020
@johnleider johnleider modified the milestones: v2.4.0, v2.5.0 Dec 22, 2020
@KaelWD KaelWD removed this from the v2.5.0 milestone Apr 24, 2021
@KaelWD KaelWD added this to the v3.0.0 milestone Apr 6, 2022
@KaelWD KaelWD removed the S: has PR The issue has a pending Pull Request label Apr 6, 2022
@KaelWD
Copy link
Member

KaelWD commented Apr 6, 2022

An item slot was added in v3 with #14813

@KaelWD KaelWD closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCarousel VCarousel T: feature A new feature
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants