Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Mobile: Back button does not respect in page modal dialogue. #4574

Closed
ghost opened this issue Jul 11, 2018 · 1 comment
Closed
Labels
duplicate The issue has already been reported

Comments

@ghost
Copy link

ghost commented Jul 11, 2018

Versions and Environment

Vuetify: 1.1.0-rc.3
Vue: 2.5.17-beta.0
Browsers: Chrome 67.0.3396.87
OS: Android 8.1.0

Steps to reproduce

Go here:

https://vuetifyjs.com/en/components/dialogs

  1. Click the " click me " red button
  2. The dialog opens.
  3. Now click the mobile back button.

The dialog should close on mobile, rather than doing a full page reload of whatever is in the history.

Btw this is exactly the tactic Google uses to make their web mobile products better. It's a huge cognitive difference for the user experience. I really implore you to consider this.

Expected Behavior

The dialog should close without a page navigation backwards.

Actual Behavior

It navigates backwards.

Reproduction Link

https://github.com/vuetifyjs/vuetify/blob/dev/src/components/VDialog/VDialog.js

Other comments

I would make a global rule for controlling this that can be customised. This is because there are so many devices these days and embedding options.

For example if using this for an electron desktop you might not want this functionality.

@KaelWD
Copy link
Member

KaelWD commented Jul 11, 2018

Duplicate of #1793

@KaelWD KaelWD marked this as a duplicate of #1793 Jul 11, 2018
@KaelWD KaelWD closed this as completed Jul 11, 2018
@KaelWD KaelWD added the duplicate The issue has already been reported label Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate The issue has already been reported
Projects
None yet
Development

No branches or pull requests

1 participant