Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Using max-width props of v-menu in v-toolbar after v-spacer offsets the menu to the left #5498

Closed
lukadriel7 opened this issue Nov 1, 2018 · 0 comments · Fixed by #6193
Closed

[Bug Report] Using max-width props of v-menu in v-toolbar after v-spacer offsets the menu to the left #5498

lukadriel7 opened this issue Nov 1, 2018 · 0 comments · Fixed by #6193
Assignees
@johnleider
Labels
T: bug Functionality that does not work as intended/expected
Milestone
v1.4.x

Comments

@lukadriel7
Copy link

Versions and Environment

Vuetify: 1.3.5
Vue: 2.5.17
Browsers: Firefox 63.0
OS: Windows 10

Steps to reproduce

  1. Create a v-toolbar
  2. Add a v-spacer
  3. Add a v-menu and set max-width

Expected Behavior

The menu should stay at the same place

Actual Behavior

The menu is offset to the left

Reproduction Link

https://codepen.io/lukadriel/pen/aRepYz
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Nov 1, 2018
@johnleider johnleider added this to the v1.3.x milestone Nov 1, 2018
@johnleider johnleider modified the milestones: v1.3.x, v2.x Jan 2, 2019
johnleider added a commit that referenced this issue Jan 18, 2019
@johnleider
fix(VMenu): update totalWidth calculation
b01b8a1 
fixes #5498
@johnleider johnleider self-assigned this Jan 18, 2019
@johnleider johnleider modified the milestones: v2.x.x, v1.4.x Jan 18, 2019
@johnleider johnleider mentioned this issue Jan 18, 2019
Merged
johnleider added a commit that referenced this issue Jan 18, 2019
@johnleider
fix(VMenu): improve position when using offset, width and attach props (
bfad3d8 
#6193)

* fix(VMenu): apply correct left position with attach

using attach/max-width/left/offset-x causes menu to not be placed correctly

* fix(VMenu): update totalWidth calculation

fixes #5498

* test(menuable): fix unit tests
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v1.4.x
Development

Successfully merging a pull request may close this issue.

Fix/menu position vuetifyjs/vuetify
2 participants
@johnleider @lukadriel7