Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Tree View component fails when replacing list with new list of same size #6181

Closed
bo-pedersen opened this issue Jan 17, 2019 · 2 comments · Fixed by #6202
Closed

[Bug Report] Tree View component fails when replacing list with new list of same size #6181

bo-pedersen opened this issue Jan 17, 2019 · 2 comments · Fixed by #6202
Assignees
@nekosaur
Labels
T: bug Functionality that does not work as intended/expected
Milestone
v1.4.x

Comments

@bo-pedersen
Copy link

Versions and Environment

Vuetify: 1.4.1
Vue: 2.5.22
Browsers: Chrome 71.0.3578.80
OS: Windows 10

Steps to reproduce

Initialize a tree view component with a list. Then replace the list with a new list with the same number of elements. See Codepen https://codepen.io/anon/pen/QzRbeq?editors=1010 for test case. This will throws the following exception in the console. Adding a larger or smaller list doesn't seem to throw an exception.

Expected Behavior

Tree view data set should be replaceable with new data set of the same size.

Actual Behavior

Seems to work on the user interface, but behaviour is not correct afterwards. Selection etc. does not work correctly. Inspecting the v-treeview component in Vue Developer Tools shows that the nodes data object refers to the old data while items props contains the updated data.

Reproduction Link

https://codepen.io/anon/pen/QzRbeq?editors=1010
@nekosaur nekosaur self-assigned this Jan 17, 2019
@nekosaur nekosaur added the pending review The issue is still pending disposition label Jan 17, 2019
@andreapier
Copy link

I am experiencing the same issue, but wasn't able to properly track it down to replacing a list of the same size.
At least until now :)

@bo-pedersen
Copy link
Author

Yes, it took quite some time to nail down to a small reproducible case. I'm glad it can be of help.

nekosaur added a commit that referenced this issue Jan 18, 2019
@nekosaur
fix(VTreeview): correcly handle updating items array of equal size
d8a9eaf 
the VTreeview component did not handle updating items prop with an array
of equal size as current array.

fixes #6181
@nekosaur nekosaur mentioned this issue Jan 18, 2019
Merged
8 tasks
johnleider pushed a commit that referenced this issue Jan 18, 2019
@nekosaur @johnleider
fix(VTreeview): correcly handle updating items array of equal size (#…
4177931 
…6202)

the VTreeview component did not handle updating items prop with an array
of equal size as current array.

fixes #6181
@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Jan 18, 2019
@johnleider johnleider added this to the v1.4.x milestone Jan 18, 2019
eubnara pushed a commit to eubnara/vuetify that referenced this issue Jan 20, 2019
@nekosaur
fix(VTreeview): correcly handle updating items array of equal size (v…
2cc7734 
…uetifyjs#6202)

the VTreeview component did not handle updating items prop with an array
of equal size as current array.

fixes vuetifyjs#6181
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nekosaur nekosaur

Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v1.4.x
Development

Successfully merging a pull request may close this issue.

fix(VTreeview): correcly handle updating items array of equal size vuetifyjs/vuetify
4 participants
@nekosaur @andreapier @johnleider @bo-pedersen