Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/menu position #6193

Merged
merged 3 commits into from Jan 18, 2019
Merged

Fix/menu position #6193

merged 3 commits into from Jan 18, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jan 18, 2019

Description

Update how calculations are derived for menu

Motivation and Context

Fix inconsistencies in various use-cases
fixes #5498

How Has This Been Tested?

jest

Markup:

```vue // Paste your FULL Playground.vue here
All arrow_drop_down
      <v-list>
        <v-list-tile
          v-for="item in items"
          :key="item"
          @click=""
        >
          <v-list-tile-title v-text="item"></v-list-tile-title>
        </v-list-tile>
      </v-list>
    </v-menu>


    <v-menu offset-y :max-width="500" :min-width="200">
      <v-btn
             slot="activator"
             color="primary"
             dark>
        Test
      </v-btn>
      <v-list>
        <v-list-tile
                     v-for="(item, index) in items2"
                     :key="index"
                     @click=""
                     >
          <v-list-tile-title>{{ item.title }}</v-list-tile-title>
        </v-list-tile>
      </v-list>
    </v-menu>

    <v-btn icon>
      <v-icon>search</v-icon>
    </v-btn>

    <v-btn icon>
      <v-icon>favorite</v-icon>
    </v-btn>

    <v-btn icon>
      <v-icon>more_vert</v-icon>
    </v-btn>
  </v-toolbar>
</v-card>
<script> export default { data: () => ({ items: [ 'All', 'Family', 'Friends', 'Coworkers' ], items2: [ { title: 'test' }, { title: 'Click Me' }, { title: 'Click Me' }, { title: 'Click Me 2' } ] }) } </script>
</details>

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] The PR title is no longer than 64 characters.
- [x] The PR is submitted to the correct branch (`master` for bug fixes and documentation updates, `dev` for new features and breaking changes).
- [x] My code follows the code style of this project.
- [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library) 

using attach/max-width/left/offset-x causes menu to not be placed correctly
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jan 18, 2019
@johnleider johnleider added this to the v1.4.x milestone Jan 18, 2019
@johnleider johnleider self-assigned this Jan 18, 2019
@vercel
Copy link

vercel bot commented Jan 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #6193 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6193      +/-   ##
==========================================
+ Coverage   89.48%   89.53%   +0.05%     
==========================================
  Files         276      276              
  Lines        6316     6318       +2     
  Branches     1593     1594       +1     
==========================================
+ Hits         5652     5657       +5     
+ Misses        545      542       -3     
  Partials      119      119
Impacted Files Coverage Δ
packages/vuetify/src/components/VMenu/VMenu.js 83.63% <ø> (ø) ⬆️
packages/vuetify/src/mixins/menuable.js 91.93% <100%> (+0.13%) ⬆️
...fy/src/components/transitions/expand-transition.js 72% <0%> (+12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7093d3d...fb4b880. Read the comment docs.

@johnleider johnleider merged commit bfad3d8 into master Jan 18, 2019
@johnleider johnleider deleted the fix/menu-position branch January 18, 2019 15:37
@johnleider johnleider removed the request for review from KaelWD January 18, 2019 15:47
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Using max-width props of v-menu in v-toolbar after v-spacer offsets the menu to the left
1 participant