Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): input generates correct type (#6434) #6482

Merged
merged 3 commits into from
Feb 24, 2019

Conversation

ClickerMonkey
Copy link
Contributor

Description

Fix the input event returning an object and not a string as expected to properly implement v-model

Motivation and Context

#6434

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #6482 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6482   +/-   ##
======================================
  Coverage    85.6%   85.6%           
======================================
  Files         298     298           
  Lines        7169    7169           
  Branches     1782    1782           
======================================
  Hits         6137    6137           
  Misses        942     942           
  Partials       90      90
Impacted Files Coverage Δ
...ages/vuetify/src/components/VCalendar/VCalendar.ts 7.44% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6faafc3...f7275da. Read the comment docs.

@johnleider johnleider merged commit 620b823 into master Feb 24, 2019
@johnleider johnleider deleted the fix/calendar-input-event branch February 24, 2019 16:44
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants