[Bug Report] Error when using a RegExp in group property of v-list-group

[garcianavalon]

Versions and Environment

Vuetify: 1.5.16
Vue: 2.6.10
Browsers: Chrome 75.0.3770.100
OS: Mac OS 10.14.5

Steps to reproduce

https://codepen.io/anon/pen/WqWxvE?editors=1111

Expected Behavior

group property in v-list-groups accepts RegExp, as stated in the docs.

Actual Behavior

Invalid prop: type check failed for prop "group". Expected String with value "/foo/g", got RegExp

Reproduction Link

https://codepen.io/anon/pen/WqWxvE?editors=1111

Other comments

This used to work, but I can't figure out in which Vuetify version

[ant1m4tt3r]

I don't have a lot of experience with the code base, but do you guys think that if we update the group prop on the VListGroup.ts file it will fix this? Now it takes a String and my proposal is to change it to receibe both Strings and RegExp.

Already checked where the 'group' prop is used and seems to be on a single validation in the 'matchRoute' method of the same file. Since it is matching the route to the group prop, I think it will do the same job if it was a RegExp.

[jacekkarczmarczyk]

Yeah, I looked at it before and I think that this is valid solution

[ant1m4tt3r]

Nice. I'll make a PR

[ant1m4tt3r]

I'm having a problem here. When I changed the group prop from group: String to whats on the first image, my editor is pointing this errors on the second image.

Already runned all the test and linting suites, and everything was fine. Can someone explain this to me? Should I commit this anyway because it's just a bug with my VSCode?

[ant1m4tt3r]

@jacekkarczmarczyk do you have any clues about this?

[jacekkarczmarczyk]

not really, it's working for me (both in vscode 1.36.1 and in yarn lint)
btw add trailing comma after null
also you can create pr and see if it fails on github

[hpo14]

why this hasnt fixed ?

[KaelWD]

That description was added in 54038a7. The group prop hasn't been touched since b8801e4.