fix(useDraggable): avoid moving out of container (#3768)

Co-authored-by: wangliangxin3 <wangliangxin3@jd.com>
vueuse · Feb 20, 2024 · 55b943a · 55b943a
1 parent c2cfd34
commit 55b943a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/packages/core/useDraggable/index.ts b/packages/core/useDraggable/index.ts
@@ -162,18 +162,17 @@ export function useDraggable(
       return
 
     const container = toValue(containerElement)
-    const containerRect = container?.getBoundingClientRect?.()
     const targetRect = toValue(target)!.getBoundingClientRect()
     let { x, y } = position.value
     if (axis === 'x' || axis === 'both') {
       x = e.clientX - pressedDelta.value.x
       if (container)
-        x = Math.min(Math.max(0, x), containerRect!.width + container.scrollLeft - targetRect!.width)
+        x = Math.min(Math.max(0, x), container.scrollWidth - targetRect!.width)
     }
     if (axis === 'y' || axis === 'both') {
       y = e.clientY - pressedDelta.value.y
       if (container)
-        y = Math.min(Math.max(0, y), containerRect!.height + container.scrollTop - targetRect!.height)
+        y = Math.min(Math.max(0, y), container.scrollHeight - targetRect!.height)
     }
     position.value = {
       x,