fix(computedWithControl): trigger only work in Vue 3

vueuse · Jul 6, 2022 · a107776 · adrianjost · Sep 8, 2022 · vaakian
1 parent 01fca3b
commit a107776
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/packages/shared/computedWithControl/index.md b/packages/shared/computedWithControl/index.md
@@ -37,6 +37,8 @@ console.log(computedRef.value) // 1
 
 ### Manual Triggering
 
+> This only works in Vue 3
+
 You can also manually trigger the update of the computed by:
 
 ```ts

diff --git a/packages/shared/computedWithControl/index.test.ts b/packages/shared/computedWithControl/index.test.ts
@@ -1,4 +1,4 @@
-import { ref } from 'vue-demi'
+import { isVue3, ref } from 'vue-demi'
 import { computedWithControl } from '.'
 
 describe('computedWithControl', () => {
@@ -19,7 +19,7 @@ describe('computedWithControl', () => {
     expect(computed.value).toBe('BAR')
   })
 
-  it('custom trigger', () => {
+  it.runIf(isVue3)('custom trigger', () => {
     let count = 0
     const computed = computedWithControl(() => {}, () => count)
 

diff --git a/packages/shared/computedWithControl/index.ts b/packages/shared/computedWithControl/index.ts
@@ -67,7 +67,9 @@ export function computedWithControl<T, S>(
     }
   }) as ComputedRefWithControl<T>
 
-  result.trigger = update
+  if (Object.isExtensible(result))
+    result.trigger = update
+
   return result
 }