From bcd2ada1cdb5a45bff058c89655cac8e1308a3f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= Date: Sat, 4 Mar 2023 22:19:08 +0800 Subject: [PATCH] fix(useWebNotification)!: should be exposed as EventHooksOn (#2821) Co-authored-by: Anthony Fu --- packages/core/useWebNotification/index.ts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/core/useWebNotification/index.ts b/packages/core/useWebNotification/index.ts index 4ccfa4e5b19..a1e7398aee5 100644 --- a/packages/core/useWebNotification/index.ts +++ b/packages/core/useWebNotification/index.ts @@ -82,7 +82,6 @@ export interface WebNotificationOptions { } export interface UseWebNotificationOptions extends WebNotificationOptions, ConfigurableWindow { - } /** @@ -114,10 +113,10 @@ export const useWebNotification = ( await Notification.requestPermission() } - const onClick: EventHook = createEventHook() - const onShow: EventHook = createEventHook() - const onError: EventHook = createEventHook() - const onClose: EventHook = createEventHook() + const { on: onClick, trigger: clickTrigger }: EventHook = createEventHook() + const { on: onShow, trigger: showTrigger }: EventHook = createEventHook() + const { on: onError, trigger: errorTrigger }: EventHook = createEventHook() + const { on: onClose, trigger: closeTrigger }: EventHook = createEventHook() // Show notification method: const show = async (overrides?: WebNotificationOptions) => { @@ -128,10 +127,11 @@ export const useWebNotification = ( const options = Object.assign({}, defaultOptions, overrides) notification.value = new Notification(options.title || '', options) - notification.value.onclick = (event: Event) => onClick.trigger(event) - notification.value.onshow = (event: Event) => onShow.trigger(event) - notification.value.onerror = (event: Event) => onError.trigger(event) - notification.value.onclose = (event: Event) => onClose.trigger(event) + notification.value.onclick = clickTrigger + notification.value.onshow = showTrigger + notification.value.onerror = errorTrigger + notification.value.onclose = closeTrigger + return notification.value }