fix(useSortable): prevent from creating multi instances (#3501)

vueuse · Nov 9, 2023 · d98468d · d98468d
1 parent e024235
commit d98468d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/packages/integrations/useSortable/index.ts b/packages/integrations/useSortable/index.ts
@@ -39,7 +39,7 @@ export function useSortable<T>(
   list: MaybeRefOrGetter<T[]>,
   options: UseSortableOptions = {},
 ): UseSortableReturn {
-  let sortable: Sortable
+  let sortable: Sortable | undefined
 
   const { document = defaultDocument, ...resetOptions } = options
 
@@ -51,12 +51,15 @@ export function useSortable<T>(
 
   const start = () => {
     const target = (typeof el === 'string' ? document?.querySelector(el) : unrefElement(el))
-    if (!target)
+    if (!target || sortable !== undefined)
       return
     sortable = new Sortable(target as HTMLElement, { ...defaultOptions, ...resetOptions })
   }
 
-  const stop = () => sortable?.destroy()
+  const stop = () => {
+    sortable?.destroy()
+    sortable = undefined
+  }
 
   const option = <K extends keyof Options>(name: K, value?: Options[K]) => {
     if (value !== undefined)