fix(useUrlSearchParams): should return initialValue (#1583)

vueuse · May 16, 2022 · fe58f8a · arcs- · Jun 23, 2022 · fe58f8a
1 parent 356da7d
commit fe58f8a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/core/useUrlSearchParams/index.test.ts b/packages/core/useUrlSearchParams/index.test.ts
@@ -46,6 +46,16 @@ describe('useUrlSearchParams', () => {
         expect(params.foo).toBe('bar')
       })
 
+      test('return initialValue', async () => {
+        const params = useUrlSearchParams(mode, {
+          initialValue: {
+            foo: 'bar',
+          },
+        })
+
+        expect(params.foo).toBe('bar')
+      })
+
       test('update params on poststate event', async () => {
         const params = useUrlSearchParams(mode)
         expect(params.foo).toBeUndefined()

diff --git a/packages/core/useUrlSearchParams/index.ts b/packages/core/useUrlSearchParams/index.ts
@@ -44,7 +44,7 @@ export function useUrlSearchParams<T extends Record<string, any> = UrlParams>(
   if (!window)
     return reactive(initialValue) as T
 
-  const state: Record<string, any> = reactive(initialValue)
+  const state: Record<string, any> = reactive({})
 
   function getRawParams() {
     if (mode === 'history') {
@@ -129,7 +129,11 @@ export function useUrlSearchParams<T extends Record<string, any> = UrlParams>(
   if (mode !== 'history')
     useEventListener(window, 'hashchange', onChanged, false)
 
-  updateState(read())
+  const initial = read()
+  if (initial.keys().next().value)
+    updateState(initial)
+  else
+    Object.assign(state, initialValue)
 
   return state as T
 }