feat(useFileDialog): new function #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Feb 8, 2022
| } | ||
|
|
||
| return { | ||
| files: readonly(files), |
There was a problem hiding this comment.
Since it's readonly, we might need an extra function reset
There was a problem hiding this comment.
I agree, a reset function would be needed
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
okxiaoliang4
reviewed
Feb 9, 2022
packages/core/useFileDialog/index.ts
Outdated
| ...options, | ||
| ...localOptions, | ||
| } | ||
| const input = document.createElement('input') |
There was a problem hiding this comment.
Is it possible to move to the useFileDialog scope? I'm worried that using the open function multiple times will create too many input.
There was a problem hiding this comment.
Moved outside useFileDialog now. Thanks!
okxiaoliang4
reviewed
Feb 9, 2022
`capture` has more optional values
antfu
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an open file dialog hook without struggling with file input.