Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(until): improved until types #1493

Merged
merged 6 commits into from Jun 16, 2022
Merged

feat(until): improved until types #1493

merged 6 commits into from Jun 16, 2022

Conversation

zojize
Copy link
Contributor

@zojize zojize commented Apr 13, 2022

Description

This PR tries to provide a better type signature for the until function.

  • Returns the unrefed value of the input from the promise
  • Narrower type inference
  • 0ms Timeout fixed now works as expected
  • Typechecking tests(I'm not sure if what I wrote is the best practice but this is an attempt, probably need to refactor)
  • toBe now works for input refs

closes #1492

Potential Problem

  • There is a bit of code duplication in the implemetation of toBe and toMatch, but I'm not sure how to abstract the logic here.
  • Type testing syntax have rooms for improvement

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu previously approved these changes May 17, 2022
@antfu antfu changed the title feat(until): improved until feat(until): improved until types Jun 16, 2022
@antfu antfu merged commit c48533f into vueuse:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve until
2 participants