Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMagicKeys)!: store key instead of keyCode in current #1506

Merged
merged 1 commit into from Jul 6, 2022

Conversation

wvffle
Copy link
Contributor

@wvffle wvffle commented Apr 19, 2022

Description

current now contains keys instead of key codes. It's now compatible with the example from docs.

Additional context

fixes #1503


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@wvffle wvffle changed the title fix: fix current keys in useMagicKeys fix(useMagicKeys): fix current keys Apr 19, 2022
@antfu antfu added this to the 9.0 milestone Jul 6, 2022
@antfu antfu changed the title fix(useMagicKeys): fix current keys fix(useMagicKeys)!: store key instead of keyCode in current Jul 6, 2022
@antfu antfu changed the base branch from main to next July 6, 2022 18:03
@antfu antfu merged commit 5e76f64 into vueuse:next Jul 6, 2022
@wvffle wvffle deleted the fix-1503 branch July 6, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current keys from useMagicKeys are as KeyA
2 participants