fix(onClickOutside): fallback to pointerup
event if click
event not propagate
#1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1520
Description
This article from 2014 clearly explains what is going on there. This PR simply workaround this issue by falling back to
pointerup
event.click
event is fired after all release events (mouseup
,touchend
,pointerup
). So, if click event is propagated normally within 50ms, timeout will be cleared. Initially, I was thinking to usetouchend
event. But the type oftouchend
event is not compatible with PointerEvent.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).