Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useVModel): add option to define defaultValue #1537

Merged
merged 4 commits into from May 3, 2022
Merged

feat(useVModel): add option to define defaultValue #1537

merged 4 commits into from May 3, 2022

Conversation

sondh0127
Copy link
Contributor

Description

Add new option defaultValue to use when props value is not passed or undefined.
It can be useful in some situations:

My case: I'm using the same component(Modal) for CREATE and UPDATE a data model. I need to check if props passed or not to make sync of existing data (from API), this is for UPDATE. And for CREATE: I need some default data to let my form work property with v-model

const type = useVModel(props, 'type', emit)
const _type = ref('')
if (type.value)
  syncRef(type, _type) // old syncRef

simply

const type = useVModel(props, 'type', emit, { defaultValue: 'none' )

Additional context

This is similar to Uncontrolled | Controlled component from
https://ahooks.js.org/hooks/use-controllable-value


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 66e82ec into vueuse:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants