Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(computedAsync): keep evaluating true for concurrent changes #1555

Merged
merged 1 commit into from May 3, 2022

Conversation

bodograumann
Copy link
Contributor

Description

When the async computation in computedAsync finish out-of-order, all but the result for the final value are discarded.
This works fine, but was previously untested afaics.
The status ref evaluating which tracks, whether a computation is currently running, was however already set to false when any computation finished, even though others were still in progress.

I have added a test which checks both and fixed the problem with evaluating, so it is now only false after the computation for the latest dependency value(s) has finished.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 23549c3 into vueuse:main May 3, 2022
@bodograumann bodograumann deleted the fix-computed-async-evaluating branch May 12, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants