fix(computedAsync): keep evaluating true for concurrent changes #1555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the async computation in
computedAsync
finish out-of-order, all but the result for the final value are discarded.This works fine, but was previously untested afaics.
The status ref
evaluating
which tracks, whether a computation is currently running, was however already set tofalse
when any computation finished, even though others were still in progress.I have added a test which checks both and fixed the problem with
evaluating
, so it is now onlyfalse
after the computation for the latest dependency value(s) has finished.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).