chore(useVModel): unified value #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okxiaoliang4
commented
May 5, 2022
| @@ -70,8 +70,10 @@ export function useVModel<P extends object, K extends keyof P, Name extends stri | |||
|
|
|||
| event = eventName || event || `update:${key}` | |||
|
|
|||
| const getValue = () => isDef(props[key!]) ? props[key!] : defaultValue | |||
There was a problem hiding this comment.
Or we can determine if the property exists in the object and thus determine if the default value is obtained
const getValue = () => Object.hasOwnProperty.call(props, key!) ? props[key!] : defaultValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1567, I don't think null should use the default value.
Update the passive option case.
Additional context
#1567
#1565
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).