Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFetch): return PromiseLike after setting method #1571

Merged
merged 1 commit into from May 16, 2022

Conversation

tobyzerner
Copy link
Contributor

Description

This fixes an oversight where if you call any of the method-setting methods (post, patch, etc.), the return value is not PromiseLike as the typings would suggest.

useFetch('http://example.com').post({ foo: 'bar' }).then(() => {}) // undefined is not a function

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

return waitUntilFinished()
.then(onFulfilled, onRejected)
},
} as any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe like this

Suggested change
} as any
} as UseFetchReturn<T> & PromiseLike<UseFetchReturn<T>>

Copy link
Contributor Author

@tobyzerner tobyzerner May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fair suggestion, I just copied the implementation of setType below :) https://github.com/vueuse/vueuse/blob/main/packages/core/useFetch/index.ts#L508

@antfu antfu merged commit 9b28628 into vueuse:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants