Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useFocus): focused should be false when element is undefined #1580

Merged
merged 2 commits into from May 16, 2022
Merged

fix(useFocus): focused should be false when element is undefined #1580

merged 2 commits into from May 16, 2022

Conversation

webfansplz
Copy link
Member

@webfansplz webfansplz commented May 8, 2022 •
edited

Description

Closes #1560

Caused by : both of the element to be undefined when the Vitepress generate HTML page.

image

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit f0067ac into vueuse:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okxiaoliang4 okxiaoliang4 okxiaoliang4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useFocus demo abnormal when refresh
3 participants
@webfansplz @okxiaoliang4 @antfu