Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watchThrottled): duplicate callback invokation when leading and trailing edges coincide #1593

Merged
merged 2 commits into from May 16, 2022

Conversation

bodograumann
Copy link
Contributor

  • chore: remove duplicate test
  • fix(throttleFilter): only invoke once when leading is also trailing edge

Description

When using watchThrottled and only exactly one change occurs in the source, the callback is still called two times: once immediately on the first change and once after the timeout.
This second call should not occur, because the leading and trailing edges actually coincide, when there is a single event only.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bodograumann bodograumann changed the title watchThrottled: fix duplicate callback invokation when leading and trailing edges coincide fix(watchThrottled): duplicate callback invokation when leading and trailing edges coincide May 12, 2022
@antfu antfu merged commit 8ba3b9d into vueuse:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants