Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toRefs): keep class prototype, close #1530 #1599

Merged
merged 2 commits into from May 16, 2022
Merged

fix(toRefs): keep class prototype, close #1530 #1599

merged 2 commits into from May 16, 2022

Conversation

chaii3
Copy link
Contributor

@chaii3 chaii3 commented May 13, 2022 •
edited

Description

Match the prototype object of target object and new object in toRefs composition.

fixes #1530

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@chaii3 chaii3 changed the title Fix classes to refs #1530 fix(toRefs): Save class instance #1530 May 13, 2022
@antfu antfu changed the title fix(toRefs): Save class instance #1530 fix(toRefs): keep class prototype, close #1530 May 16, 2022
@antfu antfu merged commit 356da7d into vueuse:main May 16, 2022
@chaii3 chaii3 deleted the fix_classes_toRefs branch May 16, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useVModel does not work with classes
2 participants
@chaii3 @antfu