Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useWindowSize): listen to the orientationchange event #1609

Merged
merged 4 commits into from Jul 6, 2022

Conversation

okxiaoliang4
Copy link
Member

@okxiaoliang4 okxiaoliang4 commented May 17, 2022

Description

new option for listen to the orientationchange event

Additional context

#1505


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@okxiaoliang4 okxiaoliang4 changed the title feat: update size when orientationchange event feat(useWindowSize): new option for listen to the orientationchange event May 18, 2022
@okxiaoliang4 okxiaoliang4 marked this pull request as ready for review May 18, 2022 07:25
@antfu
Copy link
Member

antfu commented Jul 6, 2022

I think it make sense to listen it by default

@antfu antfu changed the title feat(useWindowSize): new option for listen to the orientationchange event feat(useWindowSize): listen to the orientationchange event Jul 6, 2022
@antfu antfu merged commit c3f9567 into main Jul 6, 2022
@antfu antfu deleted the fix/useWindowSize branch July 6, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants