Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useDropZone): new function #1610

Merged
merged 6 commits into from May 31, 2022
Merged

Conversation

Julien-Martin
Copy link
Contributor

Description

Create a zone where you can drop files.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@wheatjs
Copy link
Member

wheatjs commented May 26, 2022

API feels a little weird. Typically in VueUse we pass in an element reference rather than returning handlers. I feel like we should be consistent here

@Julien-Martin
Copy link
Contributor Author

API feels a little weird. Typically in VueUse we pass in an element reference rather than returning handlers. I feel like we should be consistent here

You right, i just changed it, and that make more sense like you say and you can track which element (ref) is using the dropZone 👍

wheatjs
wheatjs previously approved these changes May 30, 2022
@wheatjs
Copy link
Member

wheatjs commented May 30, 2022

Looks good to me

wheatjs
wheatjs previously approved these changes May 30, 2022
@antfu antfu merged commit d64070e into vueuse:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants