Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useUrlSearchParams): preserve history state when updating query #1661

Merged
merged 1 commit into from Jun 16, 2022

Conversation

arcs-
Copy link
Contributor

@arcs- arcs- commented Jun 3, 2022

Description

The useUrlSearchParams function uses history.replaceState when updating query parameters.
Currently the function uses an empty object as "new state" which overrides existing state, this is an issues for router implementation.

This PR reuses the current state and title instead of overwriting it with pseudo content.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title fix(useUrlSearchParams) Preserve history state when updating query fix(useUrlSearchParams): preserve history state when updating query Jun 16, 2022
@antfu antfu merged commit 1ef51e9 into vueuse:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants