Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onClickOutside): avoid calling safari workaround on right click #1673

Merged
merged 1 commit into from Jun 16, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jun 7, 2022

Description

Fixes #1672

This PR fixes 2 issues:

1- Safari iOS workaround was being called on right clicks. This is changing the behaviour of the function. By wrapping workaround in if (e.button === 0) { we ensure it's left click.

2- composedPath returns an empty array after in setTimeout call. This is breaking the functionality of the ignore option. Fixed it by reassigning its result to itself.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 1988e9c into vueuse:main Jun 16, 2022
@sibbng sibbng deleted the fix/onclickoutside-right-click branch June 16, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onClickOutside options.ignore not work
2 participants