fix(onClickOutside): avoid calling safari workaround on right click #1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1672
This PR fixes 2 issues:
1- Safari iOS workaround was being called on right clicks. This is changing the behaviour of the function. By wrapping workaround in
if (e.button === 0) {
we ensure it's left click.2-
composedPath
returns an empty array after insetTimeout
call. This is breaking the functionality of theignore
option. Fixed it by reassigning its result to itself.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).