Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-watch-sources): fix T type for WatchCallback #1692

Merged
merged 1 commit into from Jun 16, 2022
Merged

fix(multi-watch-sources): fix T type for WatchCallback #1692

merged 1 commit into from Jun 16, 2022

Conversation

lvjiaxuan
Copy link
Contributor

Description

The watchCallback paramters type tells an unexpected union type.
36f8162f2a9ef10fd9d4248d71cd368

My PR is refered to apiWatch.ts
f62870eb524555de3208943556eb16a

Please help to review, thanks~

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit bb0ac66 into vueuse:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants