web-bluetooth dependency should be transitive #1704

sanyarnd · 2022-06-19T00:25:39Z

Describe the bug

Without "@types/web-bluetooth": "0.0.14", in my devDependencies the build fails with:

.....

node_modules/@vueuse/core/index.d.ts:396:32 - error TS2304: Cannot find name 'BluetoothDevice'.

396         onserviceadded: (this: BluetoothDevice, ev: Event) => any;
                                   ~~~~~~~~~~~~~~~

node_modules/@vueuse/core/index.d.ts:397:34 - error TS2304: Cannot find name 'BluetoothDevice'.

397         onservicechanged: (this: BluetoothDevice, ev: Event) => any;
                                     ~~~~~~~~~~~~~~~

node_modules/@vueuse/core/index.d.ts:398:34 - error TS2304: Cannot find name 'BluetoothDevice'.

398         onserviceremoved: (this: BluetoothDevice, ev: Event) => any;
                                     ~~~~~~~~~~~~~~~

node_modules/@vueuse/core/index.d.ts:401:26 - error TS2304: Cannot find name 'BluetoothRemoteGATTServer'.

401     server: vue_demi.Ref<BluetoothRemoteGATTServer | undefined>;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~

Project uses TypeScript.

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
    Memory: 13.45 GB / 31.73 GB
  Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.1.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.12.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (102.0.1245.44)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @vueuse/core: 8.7.4 => 8.7.4
    vue: 3.2.37 => 3.2.37

Used Package Manager

yarn

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Make sure this is a VueUse issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
Check that this is a concrete bug. For Q&A open a GitHub Discussion.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

Shinigami92 · 2022-06-23T12:03:49Z

Seems it's not solved via v8.7.5 🙁

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:340:15 - error TS2304: Cannot find name 'BluetoothLEScanFilter'.

340     filters?: BluetoothLEScanFilter[] | undefined;
                  ~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:348:24 - error TS2304: Cannot find name 'BluetoothServiceUUID'.

348     optionalServices?: BluetoothServiceUUID[] | undefined;
                           ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:376:36 - error TS2304: Cannot find name 'BluetoothRemoteGATTServer'.

376             connect: () => Promise<BluetoothRemoteGATTServer>;
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:378:42 - error TS2304: Cannot find name 'BluetoothServiceUUID'.

378             getPrimaryService: (service: BluetoothServiceUUID) => Promise<BluetoothRemoteGATTService>;
                                             ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:378:75 - error TS2304: Cannot find name 'BluetoothRemoteGATTService'.

378             getPrimaryService: (service: BluetoothServiceUUID) => Promise<BluetoothRemoteGATTService>;
                                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:379:44 - error TS2304: Cannot find name 'BluetoothServiceUUID'.

379             getPrimaryServices: (service?: BluetoothServiceUUID | undefined) => Promise<BluetoothRemoteGATTService[]>;
                                               ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:379:89 - error TS2304: Cannot find name 'BluetoothRemoteGATTService'.

379             getPrimaryServices: (service?: BluetoothServiceUUID | undefined) => Promise<BluetoothRemoteGATTService[]>;
                                                                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:383:41 - error TS2304: Cannot find name 'WatchAdvertisementsOptions'.

383         watchAdvertisements: (options?: WatchAdvertisementsOptions | undefined) => Promise<void>;
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:387:63 - error TS2304: Cannot find name 'BluetoothDevice'.

387             (type: "gattserverdisconnected", listener: (this: BluetoothDevice, ev: Event) => any, useCapture?: boolean | undefined): void;
                                                                  ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:388:62 - error TS2304: Cannot find name 'BluetoothDevice'.

388             (type: "advertisementreceived", listener: (this: BluetoothDevice, ev: BluetoothAdvertisingEvent) => any, useCapture?: boolean | undefined): void;
                                                                 ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:388:83 - error TS2304: Cannot find name 'BluetoothAdvertisingEvent'.

388             (type: "advertisementreceived", listener: (this: BluetoothDevice, ev: BluetoothAdvertisingEvent) => any, useCapture?: boolean | undefined): void;
                                                                                      ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:393:41 - error TS2304: Cannot find name 'BluetoothDevice'.

393         onadvertisementreceived: (this: BluetoothDevice, ev: BluetoothAdvertisingEvent) => any;
                                            ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:393:62 - error TS2304: Cannot find name 'BluetoothAdvertisingEvent'.

393         onadvertisementreceived: (this: BluetoothDevice, ev: BluetoothAdvertisingEvent) => any;
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:394:42 - error TS2304: Cannot find name 'BluetoothDevice'.

394         ongattserverdisconnected: (this: BluetoothDevice, ev: Event) => any;
                                             ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:395:46 - error TS2304: Cannot find name 'BluetoothDevice'.

395         oncharacteristicvaluechanged: (this: BluetoothDevice, ev: Event) => any;
                                                 ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:396:32 - error TS2304: Cannot find name 'BluetoothDevice'.

396         onserviceadded: (this: BluetoothDevice, ev: Event) => any;
                                   ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:397:34 - error TS2304: Cannot find name 'BluetoothDevice'.

397         onservicechanged: (this: BluetoothDevice, ev: Event) => any;
                                     ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:398:34 - error TS2304: Cannot find name 'BluetoothDevice'.

398         onserviceremoved: (this: BluetoothDevice, ev: Event) => any;
                                     ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:401:26 - error TS2304: Cannot find name 'BluetoothRemoteGATTServer'.

401     server: vue_demi.Ref<BluetoothRemoteGATTServer | undefined>;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~


Found 19 errors in the same file, starting at: node_modules/.pnpm/@vueuse+core@8.7.5_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:340

MrCube42 · 2022-07-12T06:10:41Z

Can confirm this: We still have the same problem even after upgrading to 8.7.5+ (using vue 2.6.14 and @vue/composition-api 1.4.3). We get the same error from the d.ts files as reported above #1704 (comment).

ch1035063420 · 2022-07-21T09:18:35Z

The upgrade to 8.7.5 is still unresolved
"@vueuse/core": "^8.7.5",
"@vueuse/rxjs": "^7.7.1",
"typescript": "^4.4.4",

holtwick · 2022-07-23T16:13:08Z

Also still seeing this when using "vue-tsc --noEmit"

holtwick · 2022-08-10T06:53:59Z

Any updates on this? In "@vueuse/core": "^9.1.0" I still see the error.

I was able to mitigate it by installing "@types/web-bluetooth" and adding "web-bluetooth" to "compilerOptions.types" in tsconfig.json, but it is a bit annoying to have this kind of workaround, since most users very likely are not using bluetooth features of the lib at all. Maybe this could become a separate package?

MrCube42 · 2022-08-10T15:26:13Z

Can confirm this: We still have the same problem even after upgrading to 8.7.5+ (using vue 2.6.14 and @vue/composition-api 1.4.3). We get the same error from the d.ts files as reported above #1704 (comment).

FYI: We updated to @vueuse/core 9.0.0 (using vue 2.6.14 and @vue/composition-api 1.7.0, still using vue-cli to build) and the error is gone without any extra adjustmenst.

holtwick · 2022-08-10T16:18:39Z

Thanks @MrCube42 for the feedback. I still saw the issues with the latest versions of all packages (on macOS, package manager pnpm), but maybe this is just a local setup issue. Never mind, the workaround is fine for me ;)

> vue-tsc --noEmit -p ./tsconfig.json

node_modules/.pnpm/@vueuse+core@9.1.0_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:368:15 - error TS2304: Cannot find name 'BluetoothLEScanFilter'.

368     filters?: BluetoothLEScanFilter[] | undefined;
                  ~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@9.1.0_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:376:24 - error TS2304: Cannot find name 'BluetoothServiceUUID'.

376     optionalServices?: BluetoothServiceUUID[] | undefined;
                           ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@9.1.0_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:399:17 - error TS2304: Cannot find name 'BluetoothDevice'.

399     device: Ref<BluetoothDevice | undefined>;
                    ~~~~~~~~~~~~~~~

node_modules/.pnpm/@vueuse+core@9.1.0_vue@3.2.37/node_modules/@vueuse/core/index.d.ts:401:17 - error TS2304: Cannot find name 'BluetoothRemoteGATTServer'.

401     server: Ref<BluetoothRemoteGATTServer | undefined>;
                    ~~~~~~~~~~~~~~~~~~~~~~~~~

radusuciu · 2022-08-17T14:37:48Z

Also have this issue in 9.1.0. Workaround;

Add two dev dependencies to package.json:

        "@babel/types": "^7.18.10",
        "@types/web-bluetooth": "^0.0.15",

Add web-bluetooth to compilerOptions.types in tsconfig.json.

I do not need any bluetooth related features, and had to add @babel/types since there were also some errors related to that..

- 🏷️ Add @types/web-bluetooth See vueuse/vueuse#1704 - 🔧 Set transpile target to `esnext` See vitejs/vite#6985

tkzt · 2023-04-19T02:24:21Z

Also encounter this, my workaround:

// tsconfig.json
{
  "compilerOptions": {
    ...
    "skipLibCheck": true
    ...
  }
}

radusuciu · 2023-05-25T19:36:49Z

Still see this with version 10.1.2. One more thing to add to my previous comment: @types/web-bluetooth is not necessary in package.json, but it is still required in tsconfig.json.

skipLibCheck: true in tsconfig.json works as well but that seems like too broad a solution for this specific problem as it could potentially bury legitimate errors related to other packages as well.

troyere · 2024-01-24T10:07:21Z

The problem is still there with 10.7.2

Add skipLibCheck: true : ...seriously ? In 2023, we're still there ?
Add "@types/web-bluetooth": "^0.0.15" ? I'm using vue use core, there is no way in hell I'll add that if my app does not even use bluetooth features

troyere · 2024-01-24T10:17:32Z

Got it, the problem was in my tsconfig files.

Still, don't do "that" (#1704 (comment) !)

antfu closed this as completed in 9f5b9ef Jun 19, 2022

neutron0831 added a commit to neutron0831/nlp100-ts that referenced this issue Mar 9, 2023

💚 Fix build errors

ec76d54

- 🏷️ Add @types/web-bluetooth See vueuse/vueuse#1704 - 🔧 Set transpile target to `esnext` See vitejs/vite#6985

neutron0831 added a commit to neutron0831/nlp100-ts that referenced this issue Mar 10, 2023

💚 Fix build errors

ba375c8

- 🏷️ Add @types/web-bluetooth See vueuse/vueuse#1704 - 🔧 Set transpile target to `esnext` See vitejs/vite#6985

neutron0831 added a commit to neutron0831/nlp100-ts that referenced this issue Mar 12, 2023

💚 Fix build errors

6cfb6ab

- 🏷️ Add @types/web-bluetooth See vueuse/vueuse#1704 - 🔧 Set transpile target to `esnext` See vitejs/vite#6985

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

web-bluetooth dependency should be transitive #1704

web-bluetooth dependency should be transitive #1704

sanyarnd commented Jun 19, 2022 •

edited

Shinigami92 commented Jun 23, 2022

MrCube42 commented Jul 12, 2022

ch1035063420 commented Jul 21, 2022 •

edited

holtwick commented Jul 23, 2022

holtwick commented Aug 10, 2022

MrCube42 commented Aug 10, 2022 •

edited

holtwick commented Aug 10, 2022

radusuciu commented Aug 17, 2022

tkzt commented Apr 19, 2023

radusuciu commented May 25, 2023

troyere commented Jan 24, 2024

troyere commented Jan 24, 2024

web-bluetooth dependency should be transitive #1704

web-bluetooth dependency should be transitive #1704

Comments

sanyarnd commented Jun 19, 2022 • edited

Describe the bug

System Info

Used Package Manager

Validations

Shinigami92 commented Jun 23, 2022

MrCube42 commented Jul 12, 2022

ch1035063420 commented Jul 21, 2022 • edited

holtwick commented Jul 23, 2022

holtwick commented Aug 10, 2022

MrCube42 commented Aug 10, 2022 • edited

holtwick commented Aug 10, 2022

radusuciu commented Aug 17, 2022

tkzt commented Apr 19, 2023

radusuciu commented May 25, 2023

troyere commented Jan 24, 2024

troyere commented Jan 24, 2024

sanyarnd commented Jun 19, 2022 •

edited

ch1035063420 commented Jul 21, 2022 •

edited

MrCube42 commented Aug 10, 2022 •

edited