feat(useBase64): accept objects #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jun 21, 2022
packages/core/useBase64/index.ts
Outdated
| // undefined or null | ||
| if (_target === undefined || _target === null) { resolve('') } | ||
| // undefined | ||
| if (_target === undefined) { resolve('') } |
There was a problem hiding this comment.
What's the reason that null is being excluded here?
There was a problem hiding this comment.
I think it's more obvious if we check all cases for typeof _target === 'object' in one place. I check this one in getDefaultSerialization but I'm not really sure this decision.
antfu
changed the title
antfu
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to add objects in useBase64
fixes #1677
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).