Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useAxios): awaitable execute method #1723

Merged

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Jun 27, 2022

simplify execute var definitions
migrate to async methods to silent vitest warnings

resolves #1607

BREAKING CHANGE: change return type of useAxios.execute method to PromiseLike result

Signed-off-by: Jakub Freisler jakub@frsource.org

Description

This PR make execute method of the useAxios composable an awaitable one. In general - execute function returns an PromiseLike object containing then function that resolves with newest response data.

Additional context

Other things are that are important:

  • vitest deprecated writing "callback-style tests" - so useAxios tests have been rewritten to return Promise,
  • simplified a bit the way _url and config variables are declared within execute method.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

simplify execute var definitions
migrate to async methods to silent vitest warnings

BREAKING CHANGE: change return type of useAxios.execute method to PromiseLike result

Signed-off-by: Jakub Freisler <jakub@frsource.org>
@antfu antfu merged commit 00d7323 into vueuse:main Jul 6, 2022
@antfu antfu deleted the feat/useAxios--awaitable-execute-function branch July 6, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useAxios: awaitable execute function
2 participants