feat(useAxios): awaitable execute method #1723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify execute var definitions
migrate to async methods to silent vitest warnings
resolves #1607
BREAKING CHANGE: change return type of useAxios.execute method to PromiseLike result
Signed-off-by: Jakub Freisler jakub@frsource.org
Description
This PR make
execute
method of theuseAxios
composable an awaitable one. In general - execute function returns an PromiseLike object containingthen
function that resolves with newest response data.Additional context
Other things are that are important:
vitest
deprecated writing "callback-style tests" - souseAxios
tests have been rewritten to return Promise,_url
andconfig
variables are declared withinexecute
method.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).