fix(types): reactiveOmit and reactivePick support array as second arg
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide the example you are trying to support with this? |
After the modification
Before the change
|
antfu
reviewed
Jul 4, 2022
| @@ -8,7 +9,7 @@ import { reactiveComputed } from '../reactiveComputed' | |||
| */ | |||
| export function reactiveOmit<T extends object, K extends keyof T>( | |||
| obj: T, | |||
| ...keys: K[] | |||
| ...keys: Array<Many<K>> | |||
There was a problem hiding this comment.
Suggested change
| ...keys: Array<Many<K>> | |
| ...keys: (K | K[])[] |
The abstraction of Many make understanding it a bit harder. I think it's better to wrote them as literals
There was a problem hiding this comment.
👍 Yes the literal meaning is really easier to understand
antfu
changed the title
reactiveOmit and reactivePick support array as second arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed reactiveOmit and reactivePick parameter types not supporting passed arrays
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).