Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMagicKeys): reset refs on target blur #1755

Merged
merged 3 commits into from Jul 6, 2022

Conversation

lavolpecheprogramma
Copy link
Contributor

Description

On macos when some keys are pressed in combo(cmd+p for example) open a dialog and the keyup is not triggered and the refs keep a wrong state.
I add a blur event listener so when the target lost the focus, the key refs are resetted to false.

fixes #1350

What is the purpose of this pull request?

  • [x ] Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu

This comment was marked as resolved.

@antfu antfu changed the title fix(useMagicKeys): reset refs on target blur fix(useMagicKeys)!: reset refs on target blur Jul 6, 2022
@antfu antfu changed the title fix(useMagicKeys)!: reset refs on target blur fix(useMagicKeys): reset refs on target blur Jul 6, 2022
@antfu antfu merged commit 82510b8 into vueuse:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useMagicKeys: Alt is left after switching windows using Alt + Tab
2 participants