Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useMediaQuery broke after latest update #1764

Closed
7 tasks done
wc-matteo opened this issue Jul 6, 2022 · 1 comment
Closed
7 tasks done

useMediaQuery broke after latest update #1764

wc-matteo opened this issue Jul 6, 2022 · 1 comment

Comments

@wc-matteo
Copy link

Describe the bug

the check introduced here is wrong:

typeof 'matchMedia' === 'function' will always return false since 'matchMedia' is a string

Reproduction

5a64cb53

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 4.62 GB / 15.80 GB
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE      
    Yarn: 1.22.15 - C:\Program Files\nodejs\yarn.CMD      
    npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 103.0.5060.66
    Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.44)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @vueuse/core: ^8.8.0 => 8.8.0
    @vueuse/head: ^0.7.6 => 0.7.6
    vue: ^3.2.37 => 3.2.37

Used Package Manager

pnpm

Validations

@wc-matteo wc-matteo changed the title useMediaQuery broke after last update useMediaQuery broke after latest update Jul 6, 2022
@dfreier
Copy link
Contributor

dfreier commented Jul 6, 2022

Submitted a PR: #1765

@antfu antfu closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants