Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useColorMode): resolve auto to preferred mode internally #1766

Merged
merged 1 commit into from Jul 6, 2022

Conversation

dfreier
Copy link
Contributor

@dfreier dfreier commented Jul 6, 2022

Description

I recently added the emitAuto option to useColorMode (#1627).
Now I discovered a bug with that. The HTML class attribute is now being updated with auto class, which is wrong. Even if the emitAuto option is enabled and the value auto is emitted to the user of the composable, we still need to resolve that in either light or dark internally.

Additional context

How to reproduce the bug:

  1. Set your system into light mode
  2. Visit https://vueuse.org/core/usecolormode/
  3. The page should render in light mode
  4. Set your system into dark mode
  5. The page should render in dark mode
  6. Press the green button until it displays Auto again
  7. The page renders in light mode, which is wrong

With this fix, the page correctly renders in dark for step 7).
Note: Fix only works with this other fix for useMediaQuery #1765

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 092cb19 into vueuse:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants