Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useTrunc): new function #1838

Merged
merged 8 commits into from Jul 17, 2022
Merged

feat(useTrunc): new function #1838

merged 8 commits into from Jul 17, 2022

Conversation

hanpei
Copy link
Contributor

@hanpei hanpei commented Jul 10, 2022

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu requested changes Jul 10, 2022
View reviewed changes
packages/math/useTrunc/index.ts Outdated Show resolved Hide resolved
packages/math/useTrunc/index.ts Outdated Show resolved Hide resolved
@hanpei hanpei changed the title feat(useTrunk): new function feat(useTrunc): new function Jul 10, 2022
@hanpei hanpei requested a review from antfu July 10, 2022 09:43
@hanpei
Copy link
Contributor Author

hanpei commented Jul 13, 2022 •
edited

i've pushed the changes, what should i do next?

@antfu antfu merged commit d5717bd into vueuse:next Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanpei @antfu