feat(useArraySome): new function #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jul 14, 2022
| list: MaybeComputedRef<MaybeComputedRef<T>[]>, | ||
| fn: (element: T, index: number, array: T[]) => boolean, | ||
| ): ComputedRef<boolean> { | ||
| return computed(() => resolveUnref(list).map(i => resolveUnref(i)).some(fn)) |
There was a problem hiding this comment.
Maybe we could unref the item when calling the function to avoid creating a new array
There was a problem hiding this comment.
Agree. Thanks for your advice
9 tasks
huynl-96
force-pushed
the
feat/useArraySome
branch
from
2f37db5
to
fedda2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
#1812
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).