Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useStyleTag): fix hydration mismatch issue #1918

Merged
merged 2 commits into from Jul 14, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jul 14, 2022

Description

The buttons in the useStyleTag demo are not working if this page is visited with full-reload. There is a hydration mismatch error on console. I thought changing the value of isLoaded immediately on client side is might be the cause of the issue. I wrapped it with nextTick. The hydration mismatch error is still there but at least the buttons are working now.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Jul 14, 2022

I think instead, we should execute the immediate load() in tryOnMounted

@sibbng
Copy link
Member Author

sibbng commented Jul 14, 2022

I think instead, we should execute the immediate load() in tryOnMounted

It's worked 👍

@antfu antfu merged commit 71df646 into vueuse:main Jul 14, 2022
@sibbng sibbng deleted the docs/usestyletag-fix-demo branch July 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants