Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeechSynthesis Demo - changing Language reverts to first selection on Speak #1928

Closed
7 tasks done
saschwarz opened this issue Jul 15, 2022 · 2 comments · Fixed by #1930
Closed
7 tasks done

SpeechSynthesis Demo - changing Language reverts to first selection on Speak #1928

saschwarz opened this issue Jul 15, 2022 · 2 comments · Fixed by #1930

Comments

@saschwarz
Copy link

Describe the bug

I was looking at: https://vueuse.org/core/usespeechsynthesis/#demo
and noticed if I change the Language input from the default (first) selection in the select list as soon as I press the Speak button the selection changes back to the first selection and the voice used is also the first selection.

I have tested it on my OSX machine using Safari and Chrome with the same result.

Reproduction

https://vueuse.org/core/usespeechsynthesis/#demo

System Info

System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 31.05 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.3.0 - ~/.nvm/versions/node/v18.3.0/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v18.3.0/bin/npm
    Watchman: 2022.06.27.00 - /usr/local/bin/watchman
  npmPackages:
    @vueuse/core: ^8.9.3 => 8.9.3 
    vue: ^3.2.21 => 3.2.37

Used Package Manager

npm

Validations

@saschwarz saschwarz changed the title SpeechSynthesis Demo - changing Language always reverts to first selection SpeechSynthesis Demo - changing Language reverts to first selection on Speak Jul 15, 2022
@saschwarz
Copy link
Author

Clarifying: if you select a different voice and that voice has the same lang as the already selected voice then the language select list reverts to the initial voice in that language and the voice used is the first one with the matching lang.

@sibbng
Copy link
Member

sibbng commented Jul 16, 2022

I fixed this in #1882 but it's on next branch and will be released as part of v9. I just made another PR (#1930) to fix v8 demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants