Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useSpeechSynthesis): cancel speech if voice ref changes #1941

Merged
merged 1 commit into from Jul 17, 2022
Merged

fix(useSpeechSynthesis): cancel speech if voice ref changes #1941

merged 1 commit into from Jul 17, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jul 17, 2022

Description

  • Fixes wrongly merged demo
  • Removes duplicated onend assignment
  • Cancels speech if voice ref changes

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sibbng sibbng changed the title fix(useSpeechSynthesis): remove duplicated onend, fix demo fix(useSpeechSynthesis): cancel speech if voice ref changes Jul 17, 2022
@antfu antfu merged commit a524b37 into vueuse:main Jul 17, 2022
@sibbng sibbng deleted the fix/usespeechsynthesis branch July 18, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sibbng @antfu