Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useDateFormat): support dd, ddd and dddd formatter #1986

Merged
merged 2 commits into from Jul 29, 2022
Merged

feat(useDateFormat): support dd, ddd and dddd formatter #1986

merged 2 commits into from Jul 29, 2022

Conversation

aki77
Copy link
Contributor

@aki77 aki77 commented Jul 24, 2022

Description

Support dd, ddd and dddd format. #1478

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu requested a review from webfansplz July 26, 2022 03:49
@webfansplz
Copy link
Member

LGTM, Can you add the usage to the docs (format with locales), Thanks !

@aki77
Copy link
Contributor Author

aki77 commented Jul 26, 2022

@webfansplz

Thanks for the review!
Added usage to the docs.

@aki77
Copy link
Contributor Author

aki77 commented Jul 27, 2022

@antfu @webfansplz Thanks for the review!
What else do I need to do to get this PR merged?

@antfu antfu merged commit 5b1e005 into vueuse:main Jul 29, 2022
@aki77 aki77 deleted the dateformat branch July 31, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aki77 @webfansplz @antfu