Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useToFixed): new function #2003

Merged
merged 3 commits into from Jul 29, 2022
Merged

Conversation

FliPPeDround
Copy link
Contributor

@FliPPeDround FliPPeDround commented Jul 27, 2022

Description

Reactive toFixed

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@wheatjs
Copy link
Member

wheatjs commented Jul 27, 2022

I think either useToFixed or usePrecision would be a better name for this function. At first I think it had something to do with the css position: fixed so it might cause some confusion haha

@FliPPeDround
Copy link
Contributor Author

yes,I think its a great idea! useFixed will cause some confusions. Now it has a better name useToFixed :P

@wheatjs wheatjs changed the title feat(useFixed): new function feat(useToFixed): new function Jul 29, 2022
@wheatjs wheatjs merged commit b916a10 into vueuse:main Jul 29, 2022
@HANDSOME-YANGSHAO
Copy link

HANDSOME-YANGSHAO commented Aug 1, 2022

It`s a useful function, which integrates ceil, floor, and round to improve usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants