fix(useDevicePixelRatio): more efficient mechanism #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheatjs
previously approved these changes
Aug 5, 2022
antfu
reviewed
Aug 5, 2022
Comment on lines
23
to
30
| tryOnScopeDispose((function MqResolutionObserve(): Fn { | ||
| pixelRatio.value = window.devicePixelRatio | ||
| } | ||
|
|
||
| useEventListener(window, 'resize', handleDevicePixelRatio, { passive: true }) | ||
|
|
||
| DEVICE_PIXEL_RATIO_SCALES.forEach((dppx) => { | ||
| // listen mql events in both sides | ||
| const mqlMin = useMediaQuery(`screen and (min-resolution: ${dppx}dppx)`) | ||
| const mqlMax = useMediaQuery(`screen and (max-resolution: ${dppx}dppx)`) | ||
|
|
||
| watch([mqlMin, mqlMax], handleDevicePixelRatio) | ||
| }) | ||
| mqResolution = window.matchMedia(`(resolution: ${pixelRatio.value}dppx)`) | ||
| mqResolution.addEventListener('change', MqResolutionObserve, { once: true }) | ||
| return () => { | ||
| mqResolution.removeEventListener('change', MqResolutionObserve) | ||
| } | ||
| })()) |
There was a problem hiding this comment.
What's the reason for wraping the function like this?
There was a problem hiding this comment.
Just a short way to immediately invoke the function and passing removeEventListener to tryOnScopeDispose
antfu
approved these changes
Sep 5, 2022
|
Hi @antfu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented a more efficient mechanism for the
useDevicePixelRatiofunction that inspired by this exampleAdditional context
Currently the
useDevicePixelRatiofunction create 12*2 watchers/eventListeners (+1 window resize) to achieve the same goal, this mechanism use only 1 event listener to check if the currentresolutionchanged (once) then update the value and recursively check the new valueWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).