fix(useScroll): account for rounding errors when calculating arrivedState #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Aug 6, 2022
antfu
reviewed
Aug 6, 2022
…tate Sometimes when zooming the page to sizes other than 100% and scrolling a container all the way to the bottom right, the calculation for `arrivedState.right` and `arrivedState.bottom` would incorrectly say `false`. This is due to a [rounding error][] because `scrollTop` is a non-rounded number, while `scrollHeight` and `clientHeight` are rounded. Using the MDN documentation on `Element.scrollHeight` as guidance, this commit factors in a 1px margin of error to more accurately calculate `arrivedState.right` and `arrivedState.bottom`. [rounding error]: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight#determine_if_an_element_has_been_totally_scrolled fix #2047
antfu
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes when zooming the page to sizes other than 100% and scrolling a
container all the way to the bottom right, the calculation for
arrivedState.rightandarrivedState.bottomwould incorrectly sayfalse. This is due to a rounding error becausescrollTopis anon-rounded number, while
scrollHeightandclientHeightare rounded.Using the MDN documentation on
Element.scrollHeightas guidance,this commit factors in a 1px margin of error to more accurately
calculate
arrivedState.rightandarrivedState.bottom.fix #2047
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).