Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useURLSearchParams): avoid referencing to global location #2066

Merged
merged 1 commit into from Aug 9, 2022

Conversation

mskr
Copy link
Contributor

@mskr mskr commented Aug 9, 2022

Description

Avoid using global location variable in case it is not available. Instead access it as property on the global window object.

Additional context

I might contribute an extended version of useURLSearchParams that provides reactive access to the complete URL path instead of just the search params. Soon™


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title fix(useURLSearchParams): Avoid using global variable fix(useURLSearchParams): avoid referencing to global location Aug 9, 2022
@antfu antfu merged commit 4230032 into vueuse:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants