Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useActiveElement): use computedWithControl instead of counter ref #2093

Merged
merged 3 commits into from Aug 23, 2022

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Aug 16, 2022

Description

instead of creating a pointless counter ref to do the trigger and track,
this change is to reuse computedWithControl to trigger the document.activeElement update.

no any functionality change, just a better approach.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vaakian vaakian changed the title fix(useActiveElement): use computedWithControl fix(useActiveElement, useCurrentElement): use computedWithControl instead of counter ref Aug 18, 2022
@antfu antfu changed the title fix(useActiveElement, useCurrentElement): use computedWithControl instead of counter ref fix(useActiveElement): use computedWithControl instead of counter ref Aug 23, 2022
@antfu antfu merged commit c534e43 into vueuse:main Aug 23, 2022
@adrianjost
Copy link
Contributor

adrianjost commented Sep 8, 2022

This change unfortunately broke the useActiveElement implementation for Vue 2 applications, because the trigger of computedWithControl is only available in Vue3 environments. 😢

@vaakian vaakian deleted the useActiveElement branch September 9, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants