Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useAxios): reset error on execute #2095

Merged
merged 1 commit into from Aug 23, 2022
Merged

fix(useAxios): reset error on execute #2095

merged 1 commit into from Aug 23, 2022

Conversation

flyingTodream
Copy link
Contributor

@flyingTodream flyingTodream commented Aug 17, 2022

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@flyingTodream
Copy link
Contributor Author

it should reset the error value before request.
Otherwise, when my first request fails, I call the execute method again, even if the request is successful, the error still has a value

@antfu antfu changed the title fix: Fix the bug that the error value is not reset fix(useAxios): reset error on execute Aug 18, 2022
@antfu antfu merged commit 23d186e into vueuse:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants