Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFavicon): improve type overload #2123

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Aug 25, 2022

Description

fix for issue #2118

since MaybeReadonlyRef is declared as fn or computed
I think the no param construct should be include in the other overload.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title fix: adjust useFavicon overload declaration fix(useFavicon): improve type overload Aug 25, 2022
@antfu antfu enabled auto-merge (squash) August 25, 2022 06:29
@antfu antfu merged commit df718df into vueuse:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants